Fix error outputSchema defined but no structured output returned #11
Conversation
…atibility with the MCP package ≥ 1.10), and prevent the MCP server from auto‑updating going forward.
rekby
force-pushed
the
support-mcp-1.10
branch
from
9b37023 to
d45b95f
Compare
rekby
requested review from
Copilot and
vgvoleg
and removed request for
vgvoleg
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a compatibility issue with the MCP (Model Context Protocol) package version 1.10, which introduced automatic output schema detection through type hints. The change disables structured output for all tools to maintain backward compatibility with the existing codebase that has type hints but doesn't follow the recommended structure.
- Adds
structured_output=Falseparameter to all tool registrations to prevent auto-detection - Includes a reference to issue #12 for implementing a proper structured output solution
ydb_mcp/server.py
Outdated
| spec["handler"], | ||
| name=spec["name"], | ||
| description=spec["description"], | ||
| structured_output=False, # Structured output is temporarily disabled until proper schema definitions are implemented. See https://github.com/ydb-platform/ydb-mcp/issues/12 for details. |
There was a problem hiding this comment.
The comment should explain why structured_output is disabled, not just reference an issue. Consider: '# Disable structured output due to MCP 1.10 auto-detection breaking existing tools - see issue #12'
| structured_output=False, # Structured output is temporarily disabled until proper schema definitions are implemented. See https://github.com/ydb-platform/ydb-mcp/issues/12 for details. | |
| structured_output=False, # Disable structured output due to MCP 1.10 auto-detection breaking existing tools - see issue #12 |
Copilot uses AI. Check for mistakes.
2 participants
The mcp package add auto output schema detection by typehints in 1.10 version
modelcontextprotocol/python-sdk#1005
For our code it break all output, because we have typehint, but not follow recommended struct.
The fix need for fix work in old style.
Better fix with describe scheme #12